Enabling ci build for py-torch 2.9 on rocm#1582
Enabling ci build for py-torch 2.9 on rocm#1582renjithravindrankannath wants to merge 106 commits intospack:developfrom
Conversation
renjithravindrankannath
requested a review
from adamjstewart
as a code owner
github-actions
bot
added
python
dependencies
patch
update-package
conflicts
new-variant
labels
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/aotriton/package.py
repos/spack_repo/builtin/packages/libtree/package.py
repos/spack_repo/builtin/packages/py_torch/package.py
repos/spack_repo/builtin/packages/yaml_cpp/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/py_torch/package.py:77: [E501] line too long (100 > 99 characters)
repos/spack_repo/builtin/packages/py_torch/package.py:94: [E501] line too long (100 > 99 characters)
repos/spack_repo/builtin/packages/py_torch/package.py:95: [E501] line too long (101 > 99 characters)
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
I've updated the branch with style fixes. |
renjithravindrankannath
requested review from
afzpatel,
Copilot and
srekolam
There was a problem hiding this comment.
Pull Request Overview
Enable building and testing the PyTorch 2.8 ROCm stack by activating previously excluded PyTorch ecosystem packages, adding ROCm-specific dependencies and patches, and tightening compiler/feature constraints.
- Activate PyTorch-related Python packages in the ROCm stack environment.
- Introduce ROCm-conditional variant logic and new conflicts plus a ROCm dependency (hipsparselt) and patch for PyTorch 2.8.
- Add a compiler conflict for newer aotriton binaries.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| stacks/ml-linux-x86_64-rocm/spack.yaml | Enables previously commented PyTorch ecosystem packages in the ROCm stack. |
| repos/spack_repo/builtin/packages/py_torch/package.py | Adds ROCm-specific variant defaults, conflicts, hipsparselt dependency, and a ROCm patch for 2.8. |
| repos/spack_repo/builtin/packages/aotriton/package.py | Adds compiler conflict for binary-distributed versions. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
renjithravindrankannath
requested review from
kwryankrattiger and
zackgalbreath
as code owners
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
This reverts commit 501a60b.
…12 with older rocm versions
…12 with older rocm versions
…is built with rocm
|
@spackbot rerun pipeline |
|
I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now. One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a Please check the gitlab commit status message to see if more information is available. Detailspr head: 99fc821, gitlab commit parents: ['63bb690', '34c0eb4'] |
3 participants
No description provided.